Help Composable Finance Unbrick Their Chain
The Composable Finance team has had the same issue essentially as on Picasso chain on Kusama, so one particular cause: The team had a stray todo! in the weight calculations for pallet-democracy which doomed the chain to be bricked once the launch period elapses.
-
Public wasm file to use can be found here: https://github.com/ComposableFi/composable/releases/tag/v2.1.2
-
Preimage design:
- Preimage hash:
0xad2813b46b52fe8f38cb5af7da9c7f0f66416900070b949daa62cf92bbdc6fd7
Comments (2)
Comments (2)
I do not have experience with Rust/Substrate, but wanted to check my understanding of the issue as I am still learning... I see the todo!() – I assume it was a temporary placeholder – and I see how the else clause fails. However, I thought Kusama was used as a sort of staging/testing environment before releasing to Polkadot. Shouldn’t have catching the issue on Kusama prevented the same mistake from being made when releasing to Polkadot? Not a criticism, just trying to understand how it slipped through, and what the release process is.
The bug was tracked, but like you said it did slip through our radar as we were heavily invested in developing our runtime pallets around the time that our parachain launched on polkadot. We had drafted an upgrade to v0.9.17 but couldn't finish that PR in time for the democracy launch period to elapse on chain.
I do not have experience with Rust/Substrate, but wanted to check my understanding of the issue as I am still learning... I see the todo!() – I assume it was a temporary placeholder – and I see how the else clause fails. However, I thought Kusama was used as a sort of staging/testing environment before releasing to Polkadot. Shouldn’t have catching the issue on Kusama prevented the same mistake from being made when releasing to Polkadot? Not a criticism, just trying to understand how it slipped through, and what the release process is.
The bug was tracked, but like you said it did slip through our radar as we were heavily invested in developing our runtime pallets around the time that our parachain launched on polkadot. We had drafted an upgrade to v0.9.17 but couldn't finish that PR in time for the democracy launch period to elapse on chain.